Remove ET_ALLOCATE_LIST_OR_RETURN_ERROR from all core code for MSVC windows #6502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6502
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit be98629 with merge base 41a57e6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64952858 |
tarun292
force-pushed
the
export-D64952858
branch
from
58159f9 to
70678c5
Compare
tarun292
added a commit
that referenced
this pull request
Oct 25, 2024
…indows (#6502) Summary: Remove all instances of `ET_ALLOCATE_LIST_OR_RETURN_ERROR` from the core code and instead allocate and check for a null-pointer which is MSVC compatible. Differential Revision: D64952858
|
This pull request was exported from Phabricator. Differential Revision: D64952858 |
tarun292
added a commit
that referenced
this pull request
Oct 25, 2024
…indows (#6502) Summary: Remove all instances of `ET_ALLOCATE_LIST_OR_RETURN_ERROR` from the core code and instead allocate and check for a null-pointer which is MSVC compatible. Differential Revision: D64952858
larryliu0820
approved these changes
Oct 25, 2024
tarun292
added a commit
that referenced
this pull request
Oct 28, 2024
…indows (#6502) Summary: Remove all instances of `ET_ALLOCATE_LIST_OR_RETURN_ERROR` from the core code and instead allocate and check for a null-pointer which is MSVC compatible. Reviewed By: larryliu0820 Differential Revision: D64952858
tarun292
force-pushed
the
export-D64952858
branch
from
70678c5 to
12ec7d8
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
…indows (#6502) Summary: Remove all instances of `ET_ALLOCATE_LIST_OR_RETURN_ERROR` from the core code and instead allocate and check for a null-pointer which is MSVC compatible. Reviewed By: larryliu0820 Differential Revision: D64952858
facebook-github-bot
force-pushed
the
export-D64952858
branch
from
12ec7d8 to
e2fed44
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64952858 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64952858 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
…indows (#6502) Summary: Remove all instances of `ET_ALLOCATE_LIST_OR_RETURN_ERROR` from the core code and instead allocate and check for a null-pointer which is MSVC compatible. Reviewed By: larryliu0820 Differential Revision: D64952858
facebook-github-bot
force-pushed
the
export-D64952858
branch
from
e2fed44 to
59292a4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64952858 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
…indows (#6502) Summary: Remove all instances of `ET_ALLOCATE_LIST_OR_RETURN_ERROR` from the core code and instead allocate and check for a null-pointer which is MSVC compatible. Reviewed By: larryliu0820 Differential Revision: D64952858
facebook-github-bot
force-pushed
the
export-D64952858
branch
from
59292a4 to
95396d9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64952858 |
…indows (#6502) Summary: Remove all instances of `ET_ALLOCATE_LIST_OR_RETURN_ERROR` from the core code and instead allocate and check for a null-pointer which is MSVC compatible. Reviewed By: larryliu0820 Differential Revision: D64952858
facebook-github-bot
force-pushed
the
export-D64952858
branch
from
95396d9 to
be98629
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64952858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Remove all instances of
ET_ALLOCATE_LIST_OR_RETURN_ERRORfrom the core code and instead allocate and check for a null-pointer which is MSVC compatible.Differential Revision: D64952858